Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Admin tables adhere to appending bodyHtml and headHtml when in API mode #14390

Merged
merged 6 commits into from
Feb 20, 2024

Conversation

nfourtythree
Copy link
Contributor

No description provided.

@nfourtythree nfourtythree self-assigned this Feb 15, 2024
@lukeholder
Copy link
Member

This is working great for me. We will need this merged in before the Commerce 5 beta.

Copy link
Member

@brandonkelly brandonkelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Craft.appendHeadHtml() and Craft.appendBodyHtml() are async functions, so they need to be called with await.

@lukeholder
Copy link
Member

@brandonkelly updates work for me.

@brandonkelly brandonkelly merged commit c56d6eb into 5.0 Feb 20, 2024
@brandonkelly brandonkelly deleted the feature/admin-table-append-body-html branch February 20, 2024 14:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants